[AutoDiff] make differentiable array ops inlinable #31704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
approved these changes
May 11, 2020
|
@swift-ci please test |
rxwei
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solver in https://github.com/borglab/SwiftFusion that had some
differentiableMapanddifferentiableReducein its inner loop was spending ~50% of its time in these two operations. Switching the solver to usemapandreducechanged this to ~0%.Making
differentiableMapanddifferentiableReduce@inlinableshould fix this. (Though I haven't actually built a toolchain to confirm. This isn't urgent enough that I want to spend time building a toolchain to confirm it, so I'll just wait until this makes its way into a toolchain before confirming.)